From 87d37c6cf5b8c72be2e121af96b89b4a99c95f86 Mon Sep 17 00:00:00 2001
From: Ludovic Fernandez <ldez@users.noreply.github.com>
Date: Mon, 15 Mar 2021 08:13:54 +0100
Subject: [PATCH] Restore fast linters meaning (#1844)

* fix: remove useless conditions.

* feat: considere revive as slow.

* feat: considere linters with go analysis as slow.
---
 pkg/lint/linter/config.go     | 3 ++-
 pkg/lint/lintersdb/manager.go | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/pkg/lint/linter/config.go b/pkg/lint/linter/config.go
index 86f78e5a4b8e..d69d9144a779 100644
--- a/pkg/lint/linter/config.go
+++ b/pkg/lint/linter/config.go
@@ -35,7 +35,7 @@ func (lc *Config) ConsiderSlow() *Config {
 }
 
 func (lc *Config) IsSlowLinter() bool {
-	return lc.IsSlow || (lc.LoadMode&packages.NeedTypesInfo != 0 && lc.LoadMode&packages.NeedDeps != 0)
+	return lc.IsSlow
 }
 
 func (lc *Config) WithLoadFiles() *Config {
@@ -46,6 +46,7 @@ func (lc *Config) WithLoadFiles() *Config {
 func (lc *Config) WithLoadForGoAnalysis() *Config {
 	lc = lc.WithLoadFiles()
 	lc.LoadMode |= packages.NeedImports | packages.NeedDeps | packages.NeedExportsFile | packages.NeedTypesSizes
+	lc.IsSlow = true
 	return lc
 }
 
diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
index b8a84ac973a6..50083fa36a6f 100644
--- a/pkg/lint/lintersdb/manager.go
+++ b/pkg/lint/lintersdb/manager.go
@@ -376,6 +376,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithURL("https://github.com/nishanths/predeclared"),
 		linter.NewConfig(golinters.NewRevive(reviveCfg)).
 			WithPresets(linter.PresetStyle).
+			ConsiderSlow().
 			WithURL("https://github.com/mgechev/revive"),
 		linter.NewConfig(golinters.NewDurationCheck()).
 			WithPresets(linter.PresetBugs).