diff --git a/pkg/golinters/importas.go b/pkg/golinters/importas.go index 0a044f65b46b..88e34a83bdd9 100644 --- a/pkg/golinters/importas.go +++ b/pkg/golinters/importas.go @@ -24,6 +24,9 @@ func NewImportAs(settings *config.ImportAsSettings) *goanalysis.Linter { if settings == nil { return } + if len(settings.Alias) == 0 { + lintCtx.Log.Infof("importas settings found, but no aliases listed. List aliases under alias: key.") // nolint: misspell + } err := analyzer.Flags.Set("no-unaliased", strconv.FormatBool(settings.NoUnaliased)) if err != nil { diff --git a/test/testdata/configs/importas_noalias.yml b/test/testdata/configs/importas_noalias.yml new file mode 100644 index 000000000000..ad94e57ebe6b --- /dev/null +++ b/test/testdata/configs/importas_noalias.yml @@ -0,0 +1,4 @@ +linters-settings: + importas: + fff: fmt + std_os: os diff --git a/test/testdata/importas_noalias.go b/test/testdata/importas_noalias.go new file mode 100644 index 000000000000..64bd349131ea --- /dev/null +++ b/test/testdata/importas_noalias.go @@ -0,0 +1,15 @@ +//args: -Eimportas +//config_path: testdata/configs/importas_noalias.yml +package testdata + +import ( + wrong_alias "fmt" + "os" + wrong_alias_again "os" +) + +func ImportAsNoAlias() { + wrong_alias.Println("foo") + wrong_alias_again.Stdout.WriteString("bar") + os.Stdout.WriteString("test") +}