Expire cache periodically to avoid unbounded size #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache key includes a sequence number that rotates every 7 days but because we are also using the base `golangci-lint.cache` as a restore key, the new cache will always be seeded with the full contents of the old cache. In particular for the go module cache, this leads to an ever increasing number of cached packages that never get pruned. This commit updates it so we stop using `golangci-lint.cache` as a restore key, which will force a build from an empty cache once every 7 days.
SVilgelm
approved these changes
May 11, 2022
|
released in v3.2.0: https://github.com/golangci/golangci-lint-action/releases/tag/v3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache key includes a sequence number that rotates every 7 days but because we are also using the base
golangci-lint.cacheas a restore key, the new cache will always be seeded with the full contents of the old cache.In particular for the go module cache, this leads to an ever increasing number of cached packages that never get pruned.
This commit updates it so we stop using
golangci-lint.cacheas a restore key, which will force a build from an empty cache once every 7 days.Fixes #465