Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Setup-Go #403

Merged
merged 4 commits into from Feb 24, 2022
Merged

Remove Setup-Go #403

merged 4 commits into from Feb 24, 2022

Conversation

StevenACoffman
Copy link
Contributor

@StevenACoffman StevenACoffman commented Feb 24, 2022

Per discussion in #365, this removes setup-go dep.

Until this PR is landed, we are stuck and unable to upgrade any dependencies, fix any vulns, due to the inability to build the setup-go package.

So now we remove it and then we will need to explicitly install go, like:

    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-go@v2  # <-- here
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v2

Of course, it will then require us to bump v3, but I imagine there are further documentation changes required so I am not doing that in this PR.

Signed-off-by: Steve Coffman steve@khanacademy.org

Signed-off-by: Steve Coffman <steve@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@SVilgelm
Copy link
Member

Thank you very much for this PR, it looks good to me. Just one note: please update all examples in readme, add the go installation step. I need few day for testing.

@kamilsk kamilsk self-requested a review February 24, 2022 10:48
@kamilsk
Copy link
Contributor

kamilsk commented Feb 24, 2022

great

Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add go installation step in all examples in the README.md file
  • remove skip-go-installation option from action.yml and from README.md files
  • Add a note in the readme that v3 requires explicit go installation step

@SVilgelm
Copy link
Member

Here is the PR I use for testing the changes for this action: sv-tools/mongoifc#49
everything works fine so far

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman
Copy link
Contributor Author

StevenACoffman commented Feb 24, 2022

I think I have now corrected the references you mention, but please let me know if additional references to setup-go are present, or if I should make any further edits.

@magnetikonline
Copy link

Thanks for doing this work @StevenACoffman - great to see it finally in the new @v3 action. 👍

bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Apr 24, 2023
- Turns out v3 of golint removed the go-setup dependency: golangci/golangci-lint-action#403

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Apr 24, 2023
- Turns out v3 of golint removed the go-setup dependency: golangci/golangci-lint-action#403

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Apr 24, 2023
- v3 of golint removed the go-setup dependency: golangci/golangci-lint-action#403
- Make the checkout step in the linter match the release config.
  - Good to be consistent so it's easier to tell your linting will pass
    release.

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Apr 24, 2023
- Use the new linter and checkout actions now configured in the linter
  job.
- v3 of golint removed the go-setup dependency: golangci/golangci-lint-action#403

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Apr 24, 2023
- v3 of golint and remove the go-setup dependency: golangci/golangci-lint-action#403
- Make the checkout step in the linter match the release config.
  - Good to be consistent so it's easier to tell your linting will pass
    release.

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Apr 24, 2023
- Use the new linter and checkout actions now configured in the linter
  job.
- v3 of golint removed the go-setup dependency: golangci/golangci-lint-action#403

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Jun 2, 2023
- Fix go lint version.
- v3 of golint and remove the go-setup dependency: golangci/golangci-lint-action#403
- Make the checkout step in the linter match the release config.
  - Good to be consistent so it's easier to tell your linting will pass
    release.

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Jun 2, 2023
- Fix golint version
- Use the new linter and checkout actions now configured in the linter
  job.
- v3 of golint removed the go-setup dependency: golangci/golangci-lint-action#403

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Jun 2, 2023
- Fix go lint version.
- v3 of golint and remove the go-setup dependency: golangci/golangci-lint-action#403
- Make the checkout step in the linter match the release config.
  - Good to be consistent so it's easier to tell your linting will pass
    release.

Signed-off-by: Brendan Winter <bwinter@vmware.com>
bwinter added a commit to bwinter/terraform-provider-wavefront that referenced this pull request Jun 2, 2023
- Fix golint version
- Use the new linter and checkout actions now configured in the linter
  job.
- v3 of golint removed the go-setup dependency: golangci/golangci-lint-action#403

Signed-off-by: Brendan Winter <bwinter@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants