Extract and don't mangle User Args.

[thebeline]

The current implementation mangles the contents of userArgsNames and prevents the successful checks that follow (preventing setting out-format and any of the new- parameters. This fix extracts the names with a regex without mangling them. The original iterative extraction looked creative and mildly elegant, but in testing, expanding it to not mangle the names made it less elegant, so using a regex and doing it in one go without iterating the array seemed like a simpler and more straight-forward approach.

Resolves: #199

Note: It looks like this bug has been in here for about 10 months (10cbc92), fixing this may break existing deployments. Especially considering how I just suggested using this bug as a use-case fix.

[thebeline]

Tested and behaviour confirmed: https://github.com/thebeline/OctoScreen/pull/6/checks?sha=59216435d4ad8a7101eab75378f31597bd506a56

Build failing because I did not use prettier JS. I am not familiar with that tool, and I am not sure how to resolve that.

[ldez]

Build failing because I did not use prettier JS. I am not familiar with that tool, and I am not sure how to resolve that.

You just have to run npm run format

golangci-lint-action/package.json

Line 16 in e3c53fe

"format": "prettier --write **/*.ts",

[thebeline]

Build failing because I did not use prettier JS. I am not familiar with that tool, and I am not sure how to resolve that.

You just have to run npm run format

golangci-lint-action/package.json

Line 16 in e3c53fe

"format": "prettier --write **/*.ts",

I've got that sorted now. I guess that's SOP, and stuff, but it might get mentioned in the development section of the readme.

PS: Your ESLint settings are ruthless... 🤣🤣