Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace symbols: gopls fzf style search does not work #647

Open
hyangah opened this issue Sep 15, 2020 · 2 comments
Open

workspace symbols: gopls fzf style search does not work #647

hyangah opened this issue Sep 15, 2020 · 2 comments
Labels
upstream-vscode Issues that are by problems in VS Code itself.
Milestone
vscode-go/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Sep 15, 2020 •
edited

gopls v0.5.0 supports fzf-style search syntax (@findleyr) and the following syntax is treated specially:

' for exact matching
^ for prefix matching
$ for suffix matching

I see the gopls return the expected results, but it seems they are filtered out by VSCode's additional filtering.

[Trace - 13:38:18.094 PM] Sending request 'workspace/symbol - (129)'.
Params: {"query":"^http"}


[Trace - 13:38:18.143 PM] Received response 'workspace/symbol - (129)' in 48ms.
Result: [{"name":"httpresponse.Doc","kind":14,"location":{"uri":"file:///Users/hakim/go/src/golang.org/x/tools/go/analysis/passes/httpresponse/httpresponse.go","range":{"start":{"line":18,"character":6},"end":{"line":18,"character":9}}},"containerName":"golang.org/x/tools/go/analysis/passes/httpresponse"},
...

Screen Shot 2020-09-15 at 1 46 44 PM
@hyangah
Copy link
Contributor Author

hyangah commented Sep 15, 2020

Files microsoft/vscode#106788

@hyangah hyangah added the upstream-vscode Issues that are by problems in VS Code itself. label Sep 15, 2020
@hyangah hyangah added this to To Triage in vscode-go: gopls by default Sep 17, 2020
@hyangah hyangah moved this from To Triage to Critical in vscode-go: gopls by default Sep 17, 2020
@hyangah hyangah removed this from Critical in vscode-go: gopls by default Sep 17, 2020
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Sep 17, 2020
@bsiegert
gopls: update to 0.5.0.
2e68ee2 
Memory usage

- Rewrite of caching model, resulting in significant memory usage improvements
  (@heschik).

New features

- Extract to function: Support for extracting code blocks that contain return
  statements (@joshbaum).
- Workspace symbols: Support for fzf-style search syntax (@findleyr). The
  following syntax is supported:
        ' for exact matching
        ^ for prefix matching
        $ for suffix matching

Note: This feature does not yet work in VS Code. See golang/vscode-go#647 and
microsoft/vscode#106788.

- An experimental new code lens to view GC optimization details (@pjweinb).
  Once the code lens is enabled, you will see a Toggle gc details annotation at
  the top of your file. Clicking it will show optimization diagnostics produced
  by the Go compiler, and clicking it once again will hide these diagnostics.
  Enable the code lens by adding the following to your settings:

     "codelens": {
     	"gc_details": true
     }

- go mod tidy and go mod vendor code lenses for go.mod files (@dandua98).
- Support for filling in matching in-scope variables instead of just empty
  values in fillstruct and fillreturns (@joshbaum).
- Autocompletion within import statements (@dandua98).
- Autocompletion within package declarations (@dandua98).

Improvements

- Improvements to workspace symbols ranking and fuzzy matching (@findleyr,
  @myitcv).
- Better completion suggestions in type switch case clauses and for calls to
  append, function literals, and unnamed types (@muirdm).
@findleyr findleyr mentioned this issue Oct 2, 2020
Closed
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@stamblerre stamblerre modified the milestones: Untriaged, Backlog Apr 9, 2021
@hyangah
Copy link
Contributor Author

hyangah commented Sep 22, 2021

microsoft/vscode#98125 is the upstream issue to watch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream-vscode Issues that are by problems in VS Code itself.
Projects
None yet
Milestone
vscode-go/unplanned
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot