Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: use the new []string type buildFlags #3009

Closed
hyangah opened this issue Oct 12, 2023 · 1 comment
Closed

debug: use the new []string type buildFlags #3009

hyangah opened this issue Oct 12, 2023 · 1 comment
Assignees
@suzmue
Labels
debug/config Issues for config discrepancies b/n settings.json, launch.json, launch with F5, run test, debug test Debug Issues related to the debugging functionality of the extension.
Milestone
v0.40.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 12, 2023

Newer versions of delve started to support []string type BuildFlags in the launch config. go-delve/delve#2718.
We need to change our extension to utilize it when delve is new enough to understand it.

We hope that this can help issues like
#1831
#1027

(I think there are more related open issues. I will link them later)
@hyangah hyangah added Debug Issues related to the debugging functionality of the extension. debug/config Issues for config discrepancies b/n settings.json, launch.json, launch with F5, run test, debug test labels Oct 12, 2023
@hyangah hyangah added this to the v0.41.0 milestone Oct 12, 2023
@gopherbot gopherbot added this to the Untriaged milestone Oct 12, 2023
@hyangah hyangah modified the milestones: Untriaged, v0.41.0 Oct 23, 2023
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/538057 mentions this issue: src/goDebugConfiguration: allow buildFlags passed in array

gopherbot pushed a commit that referenced this issue Nov 2, 2023
@suzmue
src/goDebugConfiguration: allow buildFlags passed in array
324992b 
For #3009

Change-Id: Icbba8db80fa6213e59152106fa01b2cf5f71ee69
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/538057
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Commit-Queue: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@hyangah hyangah modified the milestones: v0.41.0, v0.40.0 Nov 6, 2023
@suzmue suzmue closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suzmue suzmue

Labels
debug/config Issues for config discrepancies b/n settings.json, launch.json, launch with F5, run test, debug test Debug Issues related to the debugging functionality of the extension.
Projects
None yet
Milestone
v0.40.0
Development

No branches or pull requests
3 participants
@hyangah @suzmue @gopherbot