Fix wrong arm64 scaled register format #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arm64 does not have scaled register format, casue snappy test failed for current go tip: $ go version go version devel go1.17-24875e3880 Tue Apr 20 15:14:05 2021 +0000 darwin/arm64 $ go test # github.com/golang/snappy ./encode_arm64.s:385: arm64 doesn't support scaled register format ./encode_arm64.s:675: arm64 doesn't support scaled register format asm: assembly of ./encode_arm64.s failed FAIL github.com/golang/snappy [build failed] See https://go-review.googlesource.com/c/go/+/289589
|
Kindly ping @nigeltao |
|
@AWSjswinney can you have a look? |
|
As expected, the assembler in the 1.17 candidate emits the exact same instruction as previous versions (same for both changed lines): Looks good to me. |
|
@nigeltao You might want to tag a release after this merge because this issue is going to become mainstream as soon as projects start building with Go 1.17, due in about a month. |
|
@AWSjswinney @nigeltao it's not necessary anymore, since when Cherry decide to restore supporting for |
|
Great! Thanks for pointing that out. |
|
It might not be necessary, but it was easy to tag |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arm64 does not have scaled register format, casue snappy test failed for
current go tip:
See https://go-review.googlesource.com/c/go/+/289589