Use a more inclusive text for golden input. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the first chapter of Tom Sawyer with the first 400 lines of Isaac Newton's Opticks. The rawsnappy version was generated by cmd/snappytool in this repo. The extendMatch test goldens were updated as per the instructions in golden_test.go (with an update to account for the golang version of extendMatch being inlined.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full text for Tom Sawyer contains some very noninclusive language, so I'm proposing to replace it with Newton's Opticks. This same substitution was made in the Go repo, which appears to have been the original source for the text here.