Unreachable code

[VoroninArtemii]

Issue Description

The condition will always be false, so the block will never be executed.
Constant value:

protobuf/proto/text_decode.go

Line 22 in 5d5e8c0

const wrapTextUnmarshalV2 = false

Blocks IF:

protobuf/proto/text_decode.go

Lines 33 to 35 in 5d5e8c0

	if wrapTextUnmarshalV2 {
	return e.Message
	}

protobuf/proto/text_decode.go

Lines 51 to 59 in 5d5e8c0

	if wrapTextUnmarshalV2 {
	err := prototext.UnmarshalOptions{
	AllowPartial: true,
	}.Unmarshal([]byte(s), mi)
	if err != nil {
	return &ParseError{Message: err.Error()}
	}
	return checkRequiredNotSet(mi)
	} else {

And this case is in other file:

protobuf/proto/text_encode.go

Line 23 in 5d5e8c0

const wrapTextMarshalV2 = false

protobuf/proto/text_encode.go

Lines 54 to 70 in 5d5e8c0

	if wrapTextMarshalV2 {
	if m, ok := m.(encoding.TextMarshaler); ok {
	return m.MarshalText()
	}
	opts := prototext.MarshalOptions{
	AllowPartial: true,
	EmitUnknown: true,
	}
	if !tm.Compact {
	opts.Indent = " "
	}
	if !tm.ExpandAny {
	opts.Resolver = (*protoregistry.Types)(nil)
	}
	return opts.Marshal(mr.Interface())
	} else {

Similar case is in other files:

protobuf/jsonpb/decode.go

Line 25 in 5d5e8c0

const wrapJSONUnmarshalV2 = false

protobuf/jsonpb/decode.go

Lines 97 to 126 in 5d5e8c0

	if wrapJSONUnmarshalV2 {
	// NOTE: If input message is non-empty, we need to preserve merge semantics
	// of the old jsonpb implementation. These semantics are not supported by
	// the protobuf JSON specification.
	isEmpty := true
	mr.Range(func(protoreflect.FieldDescriptor, protoreflect.Value) bool {
	isEmpty = false // at least one iteration implies non-empty
	return false
	})
	if !isEmpty {
	// Perform unmarshaling into a newly allocated, empty message.
	mr = mr.New()
	// Use a defer to copy all unmarshaled fields into the original message.
	dst := proto.MessageReflect(m)
	defer mr.Range(func(fd protoreflect.FieldDescriptor, v protoreflect.Value) bool {
	dst.Set(fd, v)
	return true
	})
	}
	// Unmarshal using the v2 JSON unmarshaler.
	opts := protojson.UnmarshalOptions{
	DiscardUnknown: u.AllowUnknownFields,
	}
	if u.AnyResolver != nil {
	opts.Resolver = anyResolver{u.AnyResolver}
	}
	return opts.Unmarshal(raw, mr.Interface())
	} else {

protobuf/jsonpb/encode.go

Line 26 in 5d5e8c0

const wrapJSONMarshalV2 = false

protobuf/jsonpb/encode.go

Lines 97 to 108 in 5d5e8c0

	if wrapJSONMarshalV2 {
	opts := protojson.MarshalOptions{
	UseProtoNames: jm.OrigName,
	UseEnumNumbers: jm.EnumsAsInts,
	EmitUnpopulated: jm.EmitDefaults,
	Indent: jm.Indent,
	}
	if jm.AnyResolver != nil {
	opts.Resolver = anyResolver{jm.AnyResolver}
	}
	return opts.Marshal(proto.MessageReflect(m).Interface())
	} else {

Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Author A. Voronin.

[puellanivis]

The wrapTextUnmarshalV2 value is part of the Google-internal use of this package, and is not always false for them.

Since Google uses a duplicate of this code internally, there’s some things like this.