Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update internal/benchmarks to work with fleetbench #1570

Closed
stapelberg opened this issue Nov 1, 2023 · 2 comments
Closed

Update internal/benchmarks to work with fleetbench #1570

stapelberg opened this issue Nov 1, 2023 · 2 comments

Comments

@stapelberg
Copy link

https://github.com/protocolbuffers/protobuf-go/blob/f4a6c1f6e5c183174c1ea206ed49916e8f1dd1e8/internal/benchmarks/download_benchdata.bash#L17 is broken because the datasets no longer exist.

The benchmark should be adjusted to work with https://github.com/google/fleetbench instead.
@puellanivis
Copy link
Collaborator

Isn’t this a duplicate of #1524

@stapelberg
Copy link
Author

Definitely. Thanks for pointing that out, I didn’t see that one.

@stapelberg stapelberg closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stapelberg @puellanivis