Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: use google.golang.org/protobuf/testing/protopack for tests #1063

Merged
merged 1 commit into from Mar 20, 2020
Merged

all: use google.golang.org/protobuf/testing/protopack for tests #1063

merged 1 commit into from Mar 20, 2020

Conversation

dsnet
Copy link
Member

@dsnet dsnet commented Mar 20, 2020

Use protopack for tests instead of hard-coded binary data.

@dsnet dsnet requested a review from neild March 20, 2020 21:30
@dsnet
Copy link
Member Author

dsnet commented Mar 20, 2020

Tests fail because of #1061

@dsnet dsnet changed the title all: use testing/protopack for tests all: use google.golang.org/protobuf/testing/protopack for tests Mar 20, 2020
@dsnet
all: use testing/protopack for tests
67fc6dc 
Use protopack for tests instead of hard-coded binary data.
@dsnet dsnet merged commit 3a3cefd into api-v1 Mar 20, 2020
@dsnet dsnet deleted the protopack branch March 20, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neild neild neild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsnet @neild