Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix ill-formatted message with fmt-verbs like %s #564

Merged
merged 1 commit into from Jun 4, 2021

Conversation

motemen
Copy link
Contributor

@motemen motemen commented Jun 4, 2021

If fmt-verb strings such as %s is included in the error message, the output becomes %!s(MISSING) unintendedly.

This pull request fixes this problem.

@motemen motemen requested a review from codyoss as a code owner June 4, 2021 14:04
@codyoss
Copy link
Member

codyoss commented Jun 4, 2021

@motemen Could you please create an issue for the PR first for discussion. In that issue can you provide an example where this affects usage? Thanks.

@motemen
Copy link
Contributor Author

motemen commented Jun 4, 2021

Thanks, filed a issue at #565 .

@codyoss codyoss merged commit ab03293 into golang:master Jun 4, 2021
@codyoss
Copy link
Member

codyoss commented Jun 4, 2021

@motemen Thank you for your contribution 🎆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants