Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Add statement in Finish function about there is no need to call Finish() #556

Merged
merged 1 commit into from May 14, 2021

Conversation

sanposhiho
Copy link
Contributor

In addition to the description in NewController function's docs, it would be nice if there was a statement in Finish function's docs that there is no need to call Finish() under specific circumstances.

@sanposhiho sanposhiho requested a review from codyoss as a code owner May 13, 2021 23:45
@sanposhiho sanposhiho changed the title Fix: description about Finish Add statement in Finish function about there is no need to call Finish() May 13, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@codyoss codyoss merged commit ad820b0 into golang:master May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants