Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

feat: add InAnyOrder matcher #546

Merged
merged 4 commits into from May 17, 2021
Merged

Conversation

vvkh
Copy link
Contributor

@vvkh vvkh commented Mar 25, 2021

Draft implementation for #545

@vvkh vvkh requested a review from codyoss as a code owner March 25, 2021 20:08
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Mar 25, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Mar 25, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things, thanks for the contribution!

gomock/matchers.go Show resolved Hide resolved
gomock/matchers.go Outdated Show resolved Hide resolved
gomock/matchers_test.go Outdated Show resolved Hide resolved
@codyoss codyoss changed the title MOCK-545 add InAnyOrder matcher feat add InAnyOrder matcher Apr 16, 2021
@codyoss codyoss changed the title feat add InAnyOrder matcher feat: add InAnyOrder matcher Apr 16, 2021
@vvkh vvkh requested a review from codyoss May 12, 2021 06:08
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing, other than that looks good to me!

gomock/matchers_test.go Outdated Show resolved Hide resolved
@vvkh vvkh requested a review from codyoss May 15, 2021 10:13
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants