Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix error message in parse.go #540

Merged
merged 2 commits into from Mar 25, 2021

Conversation

sanposhiho
Copy link
Contributor

Hi team.

fixed error message becasue error strings should not be capitalized.

https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context. That is, use fmt.Errorf("something bad") not fmt.Errorf("Something bad"), so that log.Printf("Reading %s: %v", filename, err) formats without a spurious capital letter mid-message. This does not apply to logging, which is implicitly line-oriented and not combined inside other messages.

@sanposhiho sanposhiho requested a review from codyoss as a code owner March 8, 2021 12:05
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@codyoss codyoss changed the title Fix: error message on parse.go fix error message on parse.go Mar 25, 2021
@codyoss codyoss changed the title fix error message on parse.go fix error message in parse.go Mar 25, 2021
@codyoss codyoss merged commit 9336b7e into golang:master Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants