This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
fix parse arrays with const length correctly #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
suggested changes
Feb 23, 2021
codyoss
changed the title
|
Thanks for the review! I guess we should be good now. |
codyoss
approved these changes
Feb 24, 2021
|
Thank you for your contribution! 馃巻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294
Description
As described in the related issue - #294 - parsing an array with a const defined size would generate a panic.
This PR attempts fix that issue.
Would love to hear some feedback 馃檪
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes