Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Goreleaser #394

Merged
merged 1 commit into from Feb 5, 2020
Merged

Goreleaser #394

merged 1 commit into from Feb 5, 2020

Conversation

nguyenfilip
Copy link
Contributor

Fixes #389.

Description
When publishing binaries using Goreleaser use build flags.

Also remove custom archives and checksum name_templates because
Goreleaser has reasonable defaults, see https://goreleaser.com/customization/#Archive

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests

Reviewer Notes

  • The code flow looks good.
  • Tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- Improved API for custom matchers

@nguyenfilip
Goreleaser
b0b9cc8 
When publishing binaries using Goreleaser use build flags.

Also remove custom archives and checksum name_templates because
Goreleaser has reasonable defaults, see https://goreleaser.com/customization/#Archive
@nguyenfilip
Copy link
Contributor Author

@codyoss Tested only on localhost:

goreleaser release --skip-publish --skip-validate --rm-dist

Version output:

v1.4.0
Commit: b0b9cc89dd85698cbd2d03503047f068c43ff183
Date: 2020-01-31T14:22:42Z

@codyoss codyoss merged commit 0188501 into golang:master Feb 5, 2020
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codyoss codyoss codyoss approved these changes

@cvgw cvgw Awaiting requested review from cvgw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow version flag to work when built with goroleaser
2 participants
@nguyenfilip @codyoss