This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Reflect in Current Directory First #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenfilip
force-pushed
the
local-first
branch
from
fbf1acb
to
b9bb3cc
Compare
nguyenfilip
force-pushed
the
local-first
branch
from
b9bb3cc
to
042f56f
Compare
Some users have intention to run mockgen in a module aware directory with version pinned to those in `go.mod`. Always try to run reflect program in current working directory first.
nguyenfilip
force-pushed
the
local-first
branch
from
042f56f
to
2a0eb5d
Compare
|
So previously this code tried to execute reflect in
This change would make it
Is that correct? |
|
@cvgw exactly. To be more precise the execution in |
cvgw
approved these changes
Jan 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #354
Description
Reflect in Current Directory First
Some users have intention to run mockgen in a module aware directory with
version pinned to those in
go.mod.Always try to run reflect program in current working directory first.
More context about the root cause of the bug is in #354 (comment)
Submitter Checklist
Reviewer Notes
Release Notes