This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Pass -build_flags as Multiple Args #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value of -build_flags was passed to 'go' as a single argument. For example when passing -build_flags "-mod vendor", the invoked commandline was `go -mod\ vendor` and the go command errored out because there is no such arg. That has caused confusion, e.g. in golang#296 Solve this by splitting the argument by a space.
codyoss
approved these changes
Dec 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value of -build_flags was passed to 'go' as a single argument.
For example when passing -build_flags "-mod vendor", the invoked
commandline was
go -mod\ vendorand the go command errored out becausethere is no such arg.
That has caused confusion, e.g. in #296
Solve this by splitting the argument by a space.