Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Add a CI check for go vet and go lint #345

Merged
merged 10 commits into from Dec 13, 2019
Merged

Add a CI check for go vet and go lint #345

merged 10 commits into from Dec 13, 2019

Conversation

jesselang
Copy link
Contributor

Take a stab at #104. If the check works as expected, I'll look at layering on changes to resolve the golint errors.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jesselang
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jesselang
Copy link
Contributor Author

Looks like CI is working as expected now. Let's see about resolving those errors.

@jesselang jesselang marked this pull request as ready for review November 30, 2019 17:11
@jesselang
Copy link
Contributor Author

Hey @codyoss, I think this one is ready for review. Happy Thanksgiving! 🦃

@jesselang
Copy link
Contributor Author

Squashing seems like a good idea with how messy this became.

@jesselang
Copy link
Contributor Author

Anything else that needs to be done here @codyoss? Thanks!

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution! 🎆

@codyoss codyoss merged commit 41e7e9a into golang:master Dec 13, 2019
@jesselang jesselang deleted the bugfix/go-vet-and-go-lint branch December 14, 2019 02:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants