New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: update js/wasm port for Node.js 18 #57614
Comments
Change https://go.dev/cl/460575 mentions this issue: |
The js/wasm port is compatible with Node.js 14 but not Node.js 18, and we're in the middle of a freeze so it's too late to make changes now. Target the new builder for Go 1.21 and newer, and replace the "add builder" known issue with umbrella tracking issue for Node 18. Keep the current js-wasm builer with Node 14 as is so that the port doesn't deteriorate further in the meantime. It can be disabled for tip as soon as we have CLs to make all.bash pass with Node 18 all prepared. Fixes golang/go#57017. Updates golang/go#57614. Change-Id: I66cb4210f1e899329550162242c72de0da7aedda Reviewed-on: https://go-review.googlesource.com/c/build/+/460575 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/460655 mentions this issue: |
Seeing the Node.js version that was used during a particular test run should be helpful during the upcoming migration from Node.js 14 to 18. Add minimal support for that. For #57614. Change-Id: Id55ba25a7ee4a803788316d4a646cd4b6f4297e9 Reviewed-on: https://go-review.googlesource.com/c/go/+/460655 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Richard Musiol <neelance@gmail.com> Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/463915 mentions this issue: |
I've created https://go.dev/cl/463234, https://go.dev/cl/463975 and https://go.dev/cl/463976 to deal with #57516, #56860 and #57613 respectively. I think once all 3 are merged, we should be able to build successfully for Node 18. |
Change https://go.dev/cl/464036 mentions this issue: |
The js/wasm port maintainers want to start landing changes for Go 1.21 that replace Node.js 14 support with Node.js 18 support. Disable the js-wasm TryBot on tip so that work can begin. Once done, the js-wasm-node18 builder can become the new TryBot on tip, and the temporary misc-compile trybot can be removed. For golang/go#57614. Change-Id: I18ebbc69c8da2b7296dd06a5a10c8557395d600d Reviewed-on: https://go-review.googlesource.com/c/build/+/463915 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
New issue found by trybots: #58145 |
I expect the next issue we'll be hitting is #56498. |
Change https://go.dev/cl/463994 mentions this issue: |
After all.bash is passing with Node.js 18, the js/wasm builder can be enabled as a regular TryBot again (this time with Node 18 in place of Node 14). For golang/go#57614. Change-Id: I714380fba89e37275aed4144a1e8b50e0cc57884 Reviewed-on: https://go-review.googlesource.com/c/build/+/464036 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
The default NodeJS V8 stack size is 984K, which is not enough to run the regexp or go/parser tests. This commit increases the stack size to 8192K, which removes the stack size limit error. Fixes golang#56498 Fixes golang#57614 Change-Id: I357885d420daf259187403deab25ff587defa0fc Reviewed-on: https://go-review.googlesource.com/c/go/+/463994 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Julien Fabre <ju.pryz@gmail.com> Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org>
The recently-added js/wasm builder with Node.js 18 reports that all.bash doesn't pass out of the box.
This is the umbrella issue to track everything needed to migrate the js/wasm port from Node.js 14 to 18.
(It can't happen now because we're in the freeze for 1.20, so placing in 1.21 milestone.)
Maximum call stack size exceeded
testing go/parser with Node.js v18.7.0 #56498CC @golang/js, @golang/wasm, @johanbrandhorst.
The text was updated successfully, but these errors were encountered: