Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiffAbsInDuration must upgrade go version to 1.9+ #226

Closed
xu9374 opened this issue Mar 6, 2024 · 3 comments
Closed

DiffAbsInDuration must upgrade go version to 1.9+ #226

xu9374 opened this issue Mar 6, 2024 · 3 comments
Labels
Question Indicates that an issue, pull request, or discussion needs more information

Comments

@xu9374
Copy link

xu9374 commented Mar 6, 2024

in v2.3.9+DiffAbsInDuration used Duration.Abs(),but this func must in go version 1.9+,see api: audit for Go 1.19 and time: add Duration.Abs
if my go version is below 1.9, it will not compile successfully. report github.com/golang-module/carbon/v2@v2.3.10/difference.go:212:40](http://github.com/golang-module/carbon/v2@v2.3.10/difference.go:212:40): end.StdTime().Sub(c.StdTime()).Abs undefined (type time.Duration has no field or method Abs)
Do you need to update the documentation to explain that you need to use go 1.9+ after version 2.3.9+?

@xu9374 xu9374 added the Question Indicates that an issue, pull request, or discussion needs more information label Mar 6, 2024
@gouguoyin
Copy link
Member

Thank you for your feedback. I will pay attention to this issue

@gouguoyin
Copy link
Member

The next version will implement Abs method by itself

@gouguoyin
Copy link
Member

V2.3.11 has been optimized and released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Indicates that an issue, pull request, or discussion needs more information
Development

No branches or pull requests

2 participants