Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify the package name #660

Merged
merged 3 commits into from Dec 7, 2021
Merged

clarify the package name #660

merged 3 commits into from Dec 7, 2021

Conversation

khash
Copy link
Contributor

@khash khash commented Nov 29, 2021

It's not clear what package name should be used as the name of the package and the name of the driver are different in case of GCS.

@coveralls
Copy link

coveralls commented Nov 29, 2021 •
edited

Pull Request Test Coverage Report for Build 1525338457

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.738%
Totals Coverage Status
Change from base Build 1497266502: 0.0%
Covered Lines: 3731
Relevant Lines: 6462
💛 - Coveralls

dhui
dhui reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR to improve our docs!

source/google_cloud_storage/README.md Show resolved Hide resolved
@dhui dhui merged commit b69b032 into golang-migrate:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khash @coveralls @dhui