Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in Mongo Parameters #647

Closed
SJrX opened this issue Oct 26, 2021 · 2 comments
Closed

Typos in Mongo Parameters #647

SJrX opened this issue Oct 26, 2021 · 2 comments

Comments

@SJrX
Copy link
Contributor

SJrX commented Oct 26, 2021

Describe the Bug
The mongo documentation mispells the word timeout for timeout in a number of places

Steps to Reproduce
Steps to reproduce the behavior:

  1. Open this link
  2. Copy the words between x-advisory-lock- and -interval
  3. Paste it into wikitionary.

Expected Behavior
An english word.
@SJrX
Copy link
Contributor Author

SJrX commented Oct 26, 2021

I will submit a PR for this, the one question I have is whether or not you care about preserving the old behaviour.

@SJrX
Copy link
Contributor Author

SJrX commented Oct 26, 2021

Also it is doublly misspelt in the documentation: https://github.com/golang-migrate/migrate/blame/master/database/mongodb/README.md#L18
https://github.com/golang-migrate/migrate/blame/master/database/mongodb/README.md#L19

SJrX pushed a commit to SJrX/migrate that referenced this issue Oct 27, 2021
Resolves golang-migrate#647 - Fixes typos in Mongo advisory locking p…
18dd02b 
…arameters
@SJrX SJrX mentioned this issue Oct 27, 2021
Merged
SJrX pushed a commit to SJrX/migrate that referenced this issue Nov 4, 2021
PR Feedback for golang-migrate#647 - Error out when both params set
b63f099
SJrX pushed a commit to SJrX/migrate that referenced this issue Nov 5, 2021
Fixes lint issues with golang-migrate#647
fa52996
SJrX pushed a commit to SJrX/migrate that referenced this issue Nov 5, 2021
Additional PR Fixes golang-migrate#647
2fe1563
SJrX pushed a commit to SJrX/migrate that referenced this issue Nov 5, 2021
Lint fixes again golang-migrate#647
4ba4318
@dhui dhui closed this as completed in 4ba6957 Nov 5, 2021
kumaya added a commit to infobloxopen/migrate that referenced this issue Nov 26, 2021
@kumaya
Merge branch 'master' of github.com:golang-migrate/migrate into ib
b912ce7 
* 'master' of github.com:golang-migrate/migrate: (418 commits)
  Run gofmt on internal build dir
  go mod tidy
  Resolves golang-migrate#647 - Fixes typos in Mongo advisory locking parameters (golang-migrate#648)
  Bump version of autorest/adal
  Set syntax highlighting for pkger example
  Add pkger to README
  change github auth to use oauth token instead of basic.
  Use the recommended v4 in mysql README
  go mod tidy
  fix test
  Delete all rows
  Use ParseBool
  Support for AWS Keyspaces
  Update gosnowflake from v1.4.3 to v1.6.3
  Update docker client usage with breaking change
  Update dktest to v0.3.7 to fix security warnings
  revert binary file location change in docker image
  fix source/file driver
  Update build constraints
  Update golangci-lint config
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SJrX