Support for libsql and Turso #1042
Conversation
|
@avezina-ubik Can you please correct the database connection uri in Should read
In your unit tests you correctly insert the Can you also add instructions on how to connect to a turso local dev/self-hosted server (e.g.:
@dhui this might be another reason to move to individual CI tasks for each database. Then we can spin up sideband docker services and test cli commands against live local db instances to ensure the cli commands also work. Cheers, Without the scheme in the connection string you will get the following error: > migrate -source file://./migrations -verbose --database "libsql://rando-db-bryanvaz.turso.io?authToken=[TOKEN]&query" up
2024/03/09 18:12:13 error: unsupported URL scheme:
This driver supports only URLs that start with libsql://, file://, https://, http://, wss:// and ws://while this works: > migrate -source file://./migrations -verbose --database "libsql://https://rando-db-bryanvaz.turso.io?authToken=[TOKEN]" up
2024/03/09 18:15:09 Start buffering 20240309225149/u CreateCatCondoTable
2024/03/09 18:15:09 Read and execute 20240309225149/u CreateCatCondoTable
2024/03/09 18:15:09 Finished 20240309225149/u CreateCatCondoTable (read 79.775833ms, ran 122.719125ms)
2024/03/09 18:15:09 Finished after 219.338542ms
2024/03/09 18:15:09 Closing source and database |
| return version, dirty, nil | ||
| } | ||
|
|
||
| func (d *LibSQL) Drop() (err error) { |
There was a problem hiding this comment.
Please write a test for the drop command. It currently does not work:
❯ ./scripts/migrate drop
2024/03/09 18:46:33 Are you sure you want to drop the entire database schema? [y/N]
y
2024/03/09 18:46:34 Dropping the entire database schema
2024/03/09 18:46:34 error: failed to execute SQL: DROP TABLE sqlite_sequence
SQLite error: table sqlite_sequence may not be dropped in line 0: DROP TABLE sqlite_sequence in line 0: DROP TABLE sqlite_sequenceThe following table is a libsql system table and should not be dropped:
sqlite_sequence
Additionally to cover most usecases:
- Please drop views using
DROP VIEWbefore you drop tables. This list can be obtained via:SELECT name FROM sqlite_master WHERE type = 'table' - The order of the tables in the
sqlite_masteris a hint as to the order in which they were created and thus any FK constraints; therefore you should drop the tables in reverse order to avoid hitting FK constraint issues.
- Fixed Drop failing when a table has AUTOINCREMENT - Updated README.md to explain URL scheme - Updated README.md to add instructions on how to connect to a turso dev
|
Hey @bryanvaz! Thanks for the review. I updated the README and tried to prioritez the Fixed the Drop() too |
Resolves #1038