Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not documented which DBs are parallel-safe #1019

Open
oliverdain opened this issue Dec 30, 2023 · 0 comments
Open

Not documented which DBs are parallel-safe #1019

oliverdain opened this issue Dec 30, 2023 · 0 comments

Comments

@oliverdain
Copy link

Describe the Bug

The FAQ contains a helpful section titled, "What happens if two programs try and update the database at the same time?". It says this is safe/supported for some databases but I can't find a list anywhere of which are and are not supported. For example, I'm using Cloud Spanner but the docs for it don't specify if it's supported or not.

I took a quick look at the code and I see comments like, Lock implements database.Driver but doesn't do anything because Spanner only enqueues the UpdateDatabaseDdlRequest but then the ensureVersionTable method appears to aquire a lock so I'm a bit confused.

Steps to Reproduce

Pick a DB and try to figure out if it supports parallel migrations or not. At least in some cases it's impossible without reading the code.

Expected Behavior

I suggest either:

  1. In the main README where you list all the databases supported turn that into a table with a column titled "parallel safe" or similar.
  2. In the README for each driver clearly indicate what the driver does or does not support.

Migrate Version

current HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant