New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source/iofs silently ignores errors when parsing migrations #1012

Open

lillian-b opened this issue Dec 17, 2023 · 0 comments

lillian-b commented Dec 17, 2023

I made an error in setting up one of my migrations, and it was silently not being applied. I looked at the io/fs source and found this line:

migrate/source/iofs/iofs.go

Lines 61 to 64 in 856ea12

    
           m, err := source.DefaultParse(e.Name()) 
        
           if err != nil { 
        
           	continue 
        
           }

This should return an error rather than silently continuing, or the behaviour should be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment