Implementing Is(err) bool to support Go 1.13 style error checking
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
validation-error-is
branch
from
f9abfd6
to
0bcf64b
Compare
Fixes #135 by implementing `Is(err) bool` for the `ValidationError`. It both checks for the actual inner error message as well as our error flags for maximum backwards compatibility
oxisto
force-pushed
the
validation-error-is
branch
from
0bcf64b
to
278eb3c
Compare
oxisto
force-pushed
the
validation-error-is
branch
from
529ffb4
to
3eafb35
Compare
Waterdrips
approved these changes
Jan 19, 2022
This was referenced Feb 16, 2022
oxisto
added a commit
to moneszarrugh/jwt
that referenced
this pull request
Feb 21, 2023
oxisto
added a commit
to twocs/jwt
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135 by implementing
Is(err) boolfor theValidationError. It both checksfor the actual inner error message as well as our error flags for maximum backwards compatibility