Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update MIGRATION_GUIDE and VERSION_HISTORY #25

Closed
Waterdrips opened this issue May 29, 2021 · 3 comments · Fixed by #27
Closed

update MIGRATION_GUIDE and VERSION_HISTORY #25

Waterdrips opened this issue May 29, 2021 · 3 comments · Fixed by #27
Milestone

Comments

@Waterdrips
Copy link
Member

https://github.com/golang-jwt/jwt/blob/master/MIGRATION_GUIDE.md

Is currently talking about migrating from v2 ro v3, this doesnt make much sense in this reop's context.

We could update this doc to discuss how to migrate from dgrijalva/jwt-go/ to golang-jwt/jwt as a drop-in replacment, and then we can add sections in the future for new versions published from here

@oxisto
Copy link
Collaborator

oxisto commented May 29, 2021

https://github.com/golang-jwt/jwt/blob/master/MIGRATION_GUIDE.md

Is currently talking about migrating from v2 ro v3, this doesnt make much sense in this reop's context.

It might, depending on the outcome of #17.

We could update this doc to discuss how to migrate from dgrijalva/jwt-go/ to golang-jwt/jwt as a drop-in replacment, and then we can add sections in the future for new versions published from here

Yes, good idea.

@Waterdrips
Copy link
Member Author

https://github.com/golang-jwt/jwt/blob/master/MIGRATION_GUIDE.md
Is currently talking about migrating from v2 ro v3, this doesnt make much sense in this reop's context.

It might, depending on the outcome of #17.

I we dont publish a v2 and just keep with v3 then we can link people to the dgrijalva/jwt-go migration guide from v2 to v3? not sure, just seems like a 5yr old doc might not be that useful for the handful of projects id guess are still on v2

@oxisto
Copy link
Collaborator

oxisto commented May 29, 2021

https://github.com/golang-jwt/jwt/blob/master/MIGRATION_GUIDE.md
Is currently talking about migrating from v2 ro v3, this doesnt make much sense in this reop's context.

It might, depending on the outcome of #17.

I we dont publish a v2 and just keep with v3 then we can link people to the dgrijalva/jwt-go migration guide from v2 to v3? not sure, just seems like a 5yr old doc might not be that useful for the handful of projects id guess are still on v2

That sound's reasonable. So then we might restructure it in a way that briefly explains how to:

  • migrating to the new import path golang-jwt/jwt, possibly with the v3.2.1+incompatible version
  • and then link to the old plan for older releases

@oxisto oxisto added this to the v3.2.1 milestone May 29, 2021
@oxisto oxisto changed the title upgate MIGRATION_GUIDE update MIGRATION_GUIDE May 29, 2021
@oxisto oxisto changed the title update MIGRATION_GUIDE update MIGRATION_GUIDE and VERSION_HISTORY May 29, 2021
@oxisto oxisto closed this as completed in #27 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants