Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error params should be swapped #177

Closed
reneesubsplash opened this issue Mar 9, 2022 · 1 comment
Closed

error params should be swapped #177

reneesubsplash opened this issue Mar 9, 2022 · 1 comment

Comments

@reneesubsplash
Copy link

reneesubsplash commented Mar 9, 2022

jwt/claims.go

Line 59 in 279dd19

vErr.Inner = fmt.Errorf("%s by %v", delta, ErrTokenExpired)

Shouldn't it read
vErr.Inner = fmt.Errorf("%s by %v", ErrTokenExpired, delta)
so that the logs read:
"Token is expired by ______ " ? Right now the logs are showing like {"error":"20423h2m11s by token is expired"}

@oxisto
Copy link
Collaborator

oxisto commented Mar 9, 2022

Yes, you are correct :) This was fixed by #165. We did not release a new version with this fix yet.

@oxisto oxisto closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants