Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go1.18 to ci pipeline #173

Merged
merged 4 commits into from Mar 18, 2022
Merged

Add go1.18 to ci pipeline #173

merged 4 commits into from Mar 18, 2022

Conversation

mfridman
Copy link
Member

@mfridman mfridman commented Mar 1, 2022

Checking pipeline with upcoming major Go version (1.18rc1)

@@ -25,7 +25,7 @@ jobs:
strategy:
fail-fast: false
matrix:
go: [1.15, 1.16, 1.17, "1.18.0-rc1"]
go: [1.15, 1.16, 1.17, 1.18]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop 1.15 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump the go.mod version to Go 1.16 then as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe release a new version first, especially with #175 and #139?

@mfridman
Copy link
Member Author

mfridman commented Mar 16, 2022

I bumped go.mod to 1.16 minimum, and also updated the GitHub actions to v3 (both checkout and go-setup).

Note that stable key was removed, so future tags can be used with semver like normal

https://github.com/actions/setup-go/releases/tag/v3.0.0

Also released v4.4.0

@mfridman mfridman changed the title Add go1.18rc1 to ci pipeline Add go1.18 to ci pipeline Mar 18, 2022
@mfridman mfridman requested a review from oxisto March 18, 2022 01:36
@mfridman mfridman merged commit 1096e50 into main Mar 18, 2022
@mfridman mfridman deleted the go_118rc1 branch March 18, 2022 11:15
oxisto pushed a commit to moneszarrugh/jwt that referenced this pull request Feb 21, 2023
oxisto pushed a commit to twocs/jwt that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants