Support errors.Is for token extractors
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
pushed a commit
to moneszarrugh/jwt
that referenced
this pull request
Feb 21, 2023
oxisto
pushed a commit
to twocs/jwt
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the extractor expected error
ErrNoTokenInRequestis checked.This allows implementations of the
Extractorinterface to wrap errors as suggested since Go 1.13. This is mainly interesting for external Extractor implementations.This is consistent with the direction the errors are refactored in the
jwtpackage. I therefore allowed myself not to open an issue first.As the two are conceptually related, I could also open a PR towards that branch if that is desired but my understanding is that PR #136 focuses on the validation errors. @oxisto WDYT?