cmd: list supported algorithms #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
cmd-list-algs
branch
from
0a7fdad
to
914861d
Compare
mfridman
reviewed
Nov 15, 2021
cmd/jwt/main.go
Outdated
| "strings" | ||
|
|
||
| "github.com/golang-jwt/jwt/v4" | ||
| ) | ||
|
|
||
| var ( | ||
| // Options | ||
| flagAlg = flag.String("alg", "", "signing algorithm identifier") | ||
| flagAlg = flag.String("alg", "", fmt.Sprintf("signing algorithm identifier %v", algs())) |
There was a problem hiding this comment.
What are your thoughts if we made this a bit easier to read:
- flagAlg = flag.String("alg", "", fmt.Sprintf("signing algorithm identifier %v", algs()))
+ flagAlg = flag.String("alg", "", fmt.Sprintf("signing algorithm identifiers:\n%v", strings.Join(algs(), ",")))Printing out:
-alg string
signing algorithm identifiers:
ES256,ES384,ES512,EdDSA,HS256,HS384,HS512,PS256,PS384,PS512,RS256,RS384,RS512,none
instead of:
-alg string
signing algorithm identifier [ES256 ES384 ES512 EdDSA HS256 HS384 HS512 PS256 PS384 PS512 RS256 RS384 RS512 none]
There was a problem hiding this comment.
Changed to
-alg string
signing algorithm identifier, one of
ES256, ES384, ES512, EdDSA, HS256, HS384, HS512,
PS256, PS384, PS512, RS256, RS384, RS512, none
914861d
to
bac3766
Compare
The help message looks like:
```
-alg string
signing algorithm identifier, one of
ES256, ES384, ES512, EdDSA, HS256, HS384, HS512,
PS256, PS384, PS512, RS256, RS384, RS512, none
```
Also fixes golang-jwt#63
Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
mfridman
previously approved these changes
Nov 15, 2021
AlexanderYastrebov
force-pushed
the
cmd-list-algs
branch
from
bac3766
to
705b5d8
Compare
|
@mfridman Was there something else (I am not sure what |
A (positive) review automatically gets dismissed by GitHub if you add more changes to the branch. Basically to prevent that somebody approves it and then does not see the later changes. |
|
This is the specific GitHub setting in case you're curious (screenshot).
|
mfridman
approved these changes
Nov 15, 2021
oxisto
approved these changes
Nov 16, 2021
oxisto
pushed a commit
to moneszarrugh/jwt
that referenced
this pull request
Feb 21, 2023
oxisto
pushed a commit
to twocs/jwt
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The help message looks like:
Also fixes #63
Signed-off-by: Alexander Yastrebov yastrebov.alex@gmail.com