Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper Input Validation in GoGo Protobuf #752

Open
pratikdhanave-searce opened this issue Apr 7, 2022 · 1 comment
Open

Improper Input Validation in GoGo Protobuf #752

pratikdhanave-searce opened this issue Apr 7, 2022 · 1 comment

Comments

@pratikdhanave-searce
Copy link

Hi team @gpaul @gburt @gaffneyc @AlekSi @temoto
thank you for developing awesome Protocol Buffers for Go with Gadgets

I am using github.com/gogo/protobuf@1.3.2 for my project.
I am seeing security waring as following by github Dependabot alerts

An issue was discovered in GoGo Protobuf before 1.3.2. plugin/unmarshal/unmarshal.go lacks certain index validation, aka the "skippy peanut butter" issue.

can you guide me how to work on this security issue so that I can fix and create pull request ?

Thank you

@temoto
Copy link
Contributor

temoto commented Apr 7, 2022

@pratikdhanavesearce not a maintainer in this project, just added a simple tool guided patch. Dependabot says you are using version before 1.3.2. So you should upgrade to 1.3.2.

go get github.com/gogo/protobuf@1.3.2
# or
go get github.com/gogo/protobuf@latest

https://go.dev/doc/modules/managing-dependencies#getting_version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants