Remove deprecated coverage pkg #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently I found that a previous change not related to workflows is failing in my other PR gofrs#111 It is happening because the package [golang.org/x/tools/cmd/cover](https://pkg.go.dev/golang.org/x/tools/cmd/cover) is no longer active and marked as deprecated, that's why the test is falling ``` Run go get golang.org/x/tools/cmd/cover go get golang.org/x/tools/cmd/cover shell: /usr/bin/bash -e {0} env: GO111MODULE: auto GOROOT: /opt/hostedtoolcache/go/1.19.4/x64 cannot find package "golang.org/x/tools/cmd/cover" in any of: /opt/hostedtoolcache/go/1.19.4/x64/src/golang.org/x/tools/cmd/cover (from $GOROOT) /home/runner/go/src/golang.org/x/tools/cmd/cover (from $GOPATH) Error: Process completed with exit code 1. ``` The tests are focused on 1.18 e 1.19 we will be fine
rudineirk
approved these changes
Jan 18, 2023
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 448 448
=========================================
Hits 448 448 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
cameracker
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I found that a previous change not related to workflows is failing in my other PR #111
It is happening because the package golang.org/x/tools/cmd/cover is no longer active and marked as deprecated, that's why the workflow will fail.
The tests are focused on 1.18 e 1.19 and no longer needs to install
golang.org/x/tools/cmd/cover