Generator with options #111
Conversation
LeonanCarvalho
requested review from
baldanca and
dylan-bourque
and removed request for
baldanca and
dylan-bourque
LeonanCarvalho
force-pushed
the
feat/with-gen-options
branch
from
4c00e53
to
b31cacf
Compare
feat: add generator with options
LeonanCarvalho
requested review from
dylan-bourque and
baldanca
and removed request for
dylan-bourque and
baldanca
Codecov ReportBase: 100.00% // Head: 97.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
===========================================
- Coverage 100.00% 97.93% -2.07%
===========================================
Files 4 4
Lines 411 436 +25
===========================================
+ Hits 411 427 +16
- Misses 0 6 +6
- Partials 0 3 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@cameracker It would be great to have your review too :) |
|
@LeonanCarvalho thanks for the submission. What are your thoughts on the decrease of code coverage? Can we get back to 100%? |
| }), | ||
| ) | ||
|
|
||
| u, err := g.NewV1() |
There was a problem hiding this comment.
any value in checking the error message?
There was a problem hiding this comment.
I can't imagine what else to check at this point. I just kept the same behaviour as the existing tests, I didn't want to modify anything pre-existing.
I think we could include tests for nil values since there is an if with default's fallback suggested here #111 (comment) |
|
Does something flaky on those tests? I ran it on my repo and it passed |
|
I found out that pkg x/tools cover is no longer active and marked as deprecated, that's why the test is falling https://pkg.go.dev/golang.org/x/tools/cmd/cover |
Recently I found that a previous change not related to workflows is failing in my other PR gofrs#111 It is happening because the package [golang.org/x/tools/cmd/cover](https://pkg.go.dev/golang.org/x/tools/cmd/cover) is no longer active and marked as deprecated, that's why the test is falling ``` Run go get golang.org/x/tools/cmd/cover go get golang.org/x/tools/cmd/cover shell: /usr/bin/bash -e {0} env: GO111MODULE: auto GOROOT: /opt/hostedtoolcache/go/1.19.4/x64 cannot find package "golang.org/x/tools/cmd/cover" in any of: /opt/hostedtoolcache/go/1.19.4/x64/src/golang.org/x/tools/cmd/cover (from $GOROOT) /home/runner/go/src/golang.org/x/tools/cmd/cover (from $GOPATH) Error: Process completed with exit code 1. ``` The tests are focused on 1.18 e 1.19 we will be fine
|
I opened another PR to solve this workflow issue #115 I would appreciate it if you guys could also take a look at it. |
Recently I found that a previous change not related to workflows is failing in my other PR #111 It is happening because the package [golang.org/x/tools/cmd/cover](https://pkg.go.dev/golang.org/x/tools/cmd/cover) is no longer active and marked as deprecated, that's why the test is falling ``` Run go get golang.org/x/tools/cmd/cover go get golang.org/x/tools/cmd/cover shell: /usr/bin/bash -e {0} env: GO111MODULE: auto GOROOT: /opt/hostedtoolcache/go/1.19.4/x64 cannot find package "golang.org/x/tools/cmd/cover" in any of: /opt/hostedtoolcache/go/1.19.4/x64/src/golang.org/x/tools/cmd/cover (from $GOROOT) /home/runner/go/src/golang.org/x/tools/cmd/cover (from $GOPATH) Error: Process completed with exit code 1. ``` The tests are focused on 1.18 e 1.19 we will be fine
|
Thanks @LeonanCarvalho ! |
I rewrote the PR #98 authored by @mlesar based on the @theckman comments and recommendations.
Help is wanted to make it happens, this is a very desirable feature especially to generate UUIDv6 with custom timestamps.