Skip to content

all: gofmt with Go 1.19 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023
Merged

all: gofmt with Go 1.19 #110

merged 1 commit into from
Jan 7, 2023

Conversation

charlievieth
Copy link
Contributor

Go 1.19 adds doc comments. This commit runs gofmt on all the code to update the comments.

https://tip.golang.org/doc/go1.19#go-doc

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (19b5399) compared to base (ebca088).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          448       448           
=========================================
  Hits           448       448           
Impacted Files Coverage Δ
codec.go 100.00% <ø> (ø)
uuid.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dylan-bourque
Copy link
Member

Changes seem 👍 on the surface. What does the updated godoc actually look like, @charlievieth? It should be fine since the indented blocks should render well in 1.18 or earlier but it's best to verify before moving forward.

@charlievieth
Copy link
Contributor Author

Verified that there is no change in presentation (I think pkg.go.dev might already be applying these changes - all that gofmt is now doing is trying to make the "semantic meaning" of comments clearer).

The changes here are just the result of gofmt (as of 1.19) adjusting the code blocks to match the expected format (there is also one change that adds the new build tag format but thats been around for a bit).

See the "Code Blocks" section of doc/comment for more information.

@cameracker
Copy link
Collaborator

@charlievieth thanks for taking the time to clean up the code here. Would you mind rerunning this against tip master? It looks like the major rework PR yielded some conflicts 👍

Verified

This commit was signed with the committer’s verified signature.
charlievieth Charlie Vieth
Go 1.19 adds doc comments. This commit runs `gofmt` on all the code to
update the comments.

https://tip.golang.org/doc/go1.19#go-doc
@charlievieth
Copy link
Contributor Author

@charlievieth thanks for taking the time to clean up the code here. Would you mind rerunning this against tip master? It looks like the major rework PR yielded some conflicts 👍

Done and thanks for the quick review.

@cameracker cameracker merged commit 9363593 into gofrs:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants