Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/samuel/go-zookeeper #28

Open
nemith opened this issue Sep 5, 2018 · 7 comments
Open

github.com/samuel/go-zookeeper #28

nemith opened this issue Sep 5, 2018 · 7 comments
Labels
needs investigation we need to investigate some things about this project

Comments

@nemith
Copy link

nemith commented Sep 5, 2018

  • Where is the project currently hosted?
    github.com/samuel/go-zookeeper

  • What languages other than Go does the project utilize?
    Pure Go

  • When was the project's last activity?
    Jan 30th, 2018. However there are 56 active issues and 23 PRs dating back to 2013. I have had pull requests accepted in the past year, but it is spotty at best.

  • Does the project have a maintainer, or a maintainer looking for someone to take
    over the project?
    @samuel is the owner of the repo and does some maintenance. However I haven't been able to contact him recently.

  • What active projects replicate the popular functionality of this project, if any?
    None

  • What are some example projects that make use of this package?
    There are not many public project that use this library as it requires a full apache zookeeper infrastructure which is hard to setup for a open source project. However it is used in many corporations to access zk infra.

Some public repos i have found:
github.com/youtube/vitess/
github.com/sendgrid/go-solr

Browsing through just OSS on github there is Comcast, Cisco

  • Are there any outstanding critical bugs that result in the library being
    totally unusable or insecure?

We have been running into a number of bugs around leaked goroutines after a Close() call, some data races, but overall the library doesn't have critical bugs.

https://godoc.org/github.com/samuel/go-zookeeper/zk?importers

  • What else would you like to mention about the project?
@adamdecaf
Copy link
Member

adamdecaf commented Sep 5, 2018

+1 to adoption. This is used in vault and prometheus and there are tons of importers.

I've worked with this library a bit, but will help out on the issues PR's.

There seems to be another fork from the network graph. Should we talk to mesosphere?

https://github.com/mesosphere/go-zookeeper

@adamdecaf
Copy link
Member

I emailed samuel.

@nemith
Copy link
Author

nemith commented Oct 5, 2018

I emailed samuel.

I did as well a little over a month ago and got no response.

@adamdecaf
Copy link
Member

I haven't heard anything.

@nemith
Copy link
Author

nemith commented Dec 5, 2018

Any plan here? Anything I can help out with?

@adamdecaf
Copy link
Member

Dunno. The issues have been pretty quiet.

@alxn
Copy link

alxn commented Jan 3, 2019

We have heavy use of this library at Uber and had a couple of PR's merged previously (samuel/go-zookeeper#134, samuel/go-zookeeper#126), we'd like to try and get more things merged (samuel/go-zookeeper#204).

There's a few other wrappers around this library that we could contribute back too (a fake Zookeeper implementation for testing).

I think it would be a good idea to talk to mesosphere (@jdef).

@theckman theckman added the needs investigation we need to investigate some things about this project label Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation we need to investigate some things about this project
Projects
None yet
Development

No branches or pull requests

4 participants