Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] Does not implement sync.Locker #45

Open
rbcrwd opened this issue Oct 11, 2019 · 0 comments
Open

[documentation] Does not implement sync.Locker #45

rbcrwd opened this issue Oct 11, 2019 · 0 comments

Comments

@rbcrwd
Copy link

rbcrwd commented Oct 11, 2019

FYSA, contrary to the root README, this package does not implement the sync.Locker interface, primarily because Lock() has the wrong signature (returns an error rather than having no return). Feel free to close this as WONTFIX, but it'd be nice to update the doc if it's not something worth fixing in code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rbcrwd