Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 docs: fix ci badge errors #2282

Merged
merged 2 commits into from Jan 2, 2023
Merged

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jan 2, 2023

Description

This PR fixes the CI badge errors on README.md. This was introduced by the recent update of shields.io. You can read the details here: badges/shields#8671

Fixes # (issue) (skipped as this is a minor change, not a bug of fiber.)

Before
Screenshot 2023-01-03 at 2 12 18

After
Screenshot 2023-01-03 at 2 11 56

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

This only affects README.md.

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.dev/

馃憣馃徎

@welcome
Copy link

welcome bot commented Jan 2, 2023

Thanks for opening this pull request! 馃帀 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copy link
Member

@efectn efectn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update other READMEs?

@shuuji3
Copy link
Contributor Author

shuuji3 commented Jan 2, 2023

Oh, I missed other translated READMEs. OK, I'll update all of them.

@shuuji3
Copy link
Contributor Author

shuuji3 commented Jan 2, 2023

OK, I've updated all.

@efectn efectn merged commit f6b0a07 into gofiber:master Jan 2, 2023
@welcome
Copy link

welcome bot commented Jan 2, 2023

Congrats on merging your first pull request! 馃帀 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@shuuji3 shuuji3 deleted the fix-badge-errors branch January 2, 2023 17:55
@shuuji3
Copy link
Contributor Author

shuuji3 commented Jan 2, 2023

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants