Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add more detail error message in serverErrorHandler #2267

Merged
merged 1 commit into from Dec 10, 2022

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Dec 10, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Fixes #2257

Type of change

Please delete options that are not relevant.

  • New optimize (non-breaking change which adds functionality)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

Copy link
Member

@efectn efectn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think simple testcase would be great

@li-jin-gou li-jin-gou force-pushed the optimize/add_error_msg branch 2 times, most recently from 29b8b37 to 524e7cf Compare December 10, 2022 18:06
@li-jin-gou
Copy link
Contributor Author

I think simple testcase would be great

done

app_test.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou merged commit a9ddef7 into gofiber:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Fiber masks errors raised in fasthttp
2 participants