Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: latency use lowest time unit in logger middleware #2261

Merged

Conversation

li-jin-gou
Copy link
Contributor

@li-jin-gou li-jin-gou commented Dec 5, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?

Fixes #2258

Type of change

Please delete options that are not relevant.

  • New optimize(non-breaking change which adds functionality)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@li-jin-gou
Copy link
Contributor Author

There is a datarace here and I will try to fix it. https://github.com/gofiber/fiber/actions/runs/3617013466/jobs/6095488826

@ReneWerner87
Copy link
Member

let me know when the pull request is mergable and you have found or fixed the datarace problem

@li-jin-gou
Copy link
Contributor Author

let me know when the pull request is mergable and you have found or fixed the datarace problem

I haven't found the cause of this datarace yet, so I'll mention a separate PR fix😶

@ReneWerner87 ReneWerner87 merged commit efeea7a into gofiber:master Dec 10, 2022
@the-hotmann
Copy link
Contributor

Thanks mate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤗 [Question]: How to log in lowest time unit?
4 participants