Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug: fix regex constraints that contain comma #2256

Merged
merged 1 commit into from Dec 5, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Dec 4, 2022

Description

Fixes #2251

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@benz9527
Copy link

benz9527 commented Dec 5, 2022

Thx u.

@ReneWerner87 ReneWerner87 merged commit 077a5dc into master Dec 5, 2022
@efectn efectn deleted the fix-regex-constraint-comma branch December 5, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Fiber route path definition with regex which contains comma will make regex invalid
3 participants