Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix: Properly handle error of "net.ParseCIDR" in "(*App).handleTrustedProxy" #2243

Merged

Conversation

leonklingele
Copy link
Member

@leonklingele leonklingele commented Nov 26, 2022

Description

  • Do not use empty *net.IPNet in case of an error of net.ParseCIDR
  • Add test for ctx.IsProxyTrusted()
  • Optimize ctx.IsProxyTrusted() by caching method call

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

@leonklingele
Copy link
Member Author

See the individual commits for details.

Copy link
Contributor

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the title and description of your pr are not the same as most PRs. and you should refer to #2152 or #2188 etc.. and modify the title and description of the PR according to the pull request template.

@ReneWerner87
Copy link
Member

@leonklingele can you please add one more test case for this kind of behavior
and next time follow the pull request template form where you work through the checklist

@leonklingele leonklingele changed the title app: do not use empty *net.IPNet in case of an error of "net.ParseCIDR" 🩹 Fix: Properly handle error of "net.ParseCIDR" in "(*App).handleTrustedProxy" Dec 3, 2022
@leonklingele
Copy link
Member Author

Updated, ptal.

@ReneWerner87 ReneWerner87 merged commit d9d2153 into gofiber:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants