Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ShutdownWithTimeout function #2228

Merged
merged 6 commits into from Dec 19, 2022
Merged

feat: add ShutdownWithTimeout function #2228

merged 6 commits into from Dec 19, 2022

Conversation

pjebs
Copy link
Contributor

@pjebs pjebs commented Nov 21, 2022

Waiting for new tag upstream

@pjebs
Copy link
Contributor Author

pjebs commented Nov 21, 2022

See: valyala/fasthttp#1383

app.go Show resolved Hide resolved
app.go Show resolved Hide resolved
app.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@pjebs
Copy link
Contributor Author

pjebs commented Nov 28, 2022

This is now ready for release.

app.go Show resolved Hide resolved
app.go Show resolved Hide resolved
@pjebs
Copy link
Contributor Author

pjebs commented Dec 11, 2022

Can this be merged and tagged?

@efectn
Copy link
Member

efectn commented Dec 11, 2022

Can this be merged and tagged?

Can you create a PR for docs repo

@pjebs
Copy link
Contributor Author

pjebs commented Dec 11, 2022

Here is PR for docs gofiber/docs#309

app.go Show resolved Hide resolved
@pjebs
Copy link
Contributor Author

pjebs commented Dec 14, 2022

awesome work @li-jin-gou

@li-jin-gou li-jin-gou linked an issue Dec 18, 2022 that may be closed by this pull request
3 tasks
@li-jin-gou
Copy link
Contributor

LGTM

@li-jin-gou li-jin-gou changed the title add ShutdownWithTimeout function feat: add ShutdownWithTimeout function Dec 19, 2022
@li-jin-gou li-jin-gou merged commit 8889cea into gofiber:master Dec 19, 2022
@pjebs pjebs deleted the force-shutdown-with-context branch December 24, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [Feature]: Shutdown() add optional timeout
6 participants