Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug: fix mounting when mount prefix is / #2227

Merged
merged 1 commit into from Nov 20, 2022
Merged

Conversation

efectn
Copy link
Member

@efectn efectn commented Nov 20, 2022

Description

Fix mounting scenarios like

app := New()
dynamic := New()
apiserver := New()

apiroutes := apiserver.Group("/v1")
apiroutes.Get("/home", func(c *Ctx) error {
	return c.SendString("home")
})

dynamic.Mount("/api", apiserver)
app.Mount("/", dynamic)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@ReneWerner87 ReneWerner87 merged commit 291fb6e into master Nov 20, 2022
@efectn efectn deleted the fix-mount branch November 20, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants