Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bug: fix constraints when to use multiple params #2077

Merged
merged 2 commits into from Sep 8, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Sep 7, 2022

Description

Fix route patterns like:

  • /:lang<len(2)>/videos/:page<range(1,1000)>/
  • /:lang/videos/:page<range(1,1000)>/
  • /:lang<len(2)>/videos/:page/

Fixes #2076

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

remove the parameters for negative routing matches, as they are unnecessary and should not be considered there
@ReneWerner87 ReneWerner87 merged commit 35753f7 into master Sep 8, 2022
@efectn efectn deleted the fix-constraints branch September 8, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Multiple constraints does not work in routes
2 participants