Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unhandled errors in app_test.go #2071

Merged
merged 24 commits into from Sep 5, 2022
Merged

fix unhandled errors in app_test.go #2071

merged 24 commits into from Sep 5, 2022

Conversation

Kamandlou
Copy link
Contributor

No description provided.

@efectn
Copy link
Member

efectn commented Sep 2, 2022

I don't think we need to handle errors for Send(). It always returns nil. https://github.com/gofiber/fiber/blob/master/ctx.go#L1437

@Kamandlou
Copy link
Contributor Author

I don't think we need to handle errors for Send(). It always returns nil. https://github.com/gofiber/fiber/blob/master/ctx.go#L1437

Yes, it is not needed now, but there may be changes in this method that are needed in the future

@ReneWerner87 ReneWerner87 merged commit c8b1879 into gofiber:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants