Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix: EnvVar middleware parses base64 incorrectly #2069

Merged
merged 3 commits into from Sep 3, 2022

Conversation

fufuok
Copy link
Contributor

@fufuok fufuok commented Aug 31, 2022

Description

Fixes #2068

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

@fufuok fufuok changed the title Optimize envvar 馃悰 Fix: EnvVar middleware parses base64 incorrectly Aug 31, 2022
@mstrYoda
Copy link
Member

mstrYoda commented Sep 3, 2022

LGTM

@ReneWerner87 ReneWerner87 merged commit 87faeda into gofiber:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃悰 [Bug]: EnvVar middleware parsing error
3 participants